[spirv] Fix generating array type in SPIR-V #7863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: fixes taichi-dev#7855 ### Brief Summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 8f35995</samp> Fix array size encoding bug in SPIR-V backend. Use `int_immediate_number` to create SPIR-V constants for array types in `spirv_types.cpp`. ### Walkthrough <!-- copilot:walkthrough --> ### <samp>🤖 Generated by Copilot at 8f35995</samp> * Fix a bug where array size was not encoded as a SPIR-V constant ([link](https://github.com/taichi-dev/taichi/pull/7863/files?diff=unified&w=0#diff-259a89b8645aab6065eac94864cd4930be7ae91da5cb2e15307ae5fa41015962L456-R459)) * Use `int_immediate_number` to create a constant operand for `OpTypeArray` ([link](https://github.com/taichi-dev/taichi/pull/7863/files?diff=unified&w=0#diff-259a89b8645aab6065eac94864cd4930be7ae91da5cb2e15307ae5fa41015962L456-R459))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fixes #7855
Brief Summary
🤖 Generated by Copilot at 8f35995
Fix array size encoding bug in SPIR-V backend. Use
int_immediate_numberto create SPIR-V constants for array types inspirv_types.cpp.Walkthrough
🤖 Generated by Copilot at 8f35995
int_immediate_numberto create a constant operand forOpTypeArray(link)